split up remove_function_pointerst::remove_function_pointer #2870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli and
smowton
as code owners
danpoe
approved these changes
Sep 3, 2018
| const code_function_callt &code = to_code_function_call(target->code); | ||
|
|
||
| const exprt &function = code.function(); | ||
| const exprt &pointer = function.op0(); |
There was a problem hiding this comment.
Could cast to dereference_exprt and then use .pointer() to make explicit that we're expecting a dereference expression here.
| void remove_function_pointer( | ||
| goto_programt &goto_program, | ||
| goto_programt::targett target, | ||
| const functionst &functions); |
There was a problem hiding this comment.
Trying to expose this, for alternative ways of determining those functions.
tautschnig
requested changes
Sep 3, 2018
There was a problem hiding this comment.
Surely a good idea, but now we have two functions with the same name, and neither of which are documented. I don't think RTFS makes for good-enough documentation in this case. Please add a brief documentation header to the new one at least (as it is also publicly exposed), or even better: to both of them.
tautschnig
approved these changes
Sep 3, 2018
|
Done |
peterschrammel
approved these changes
Sep 3, 2018
| const code_function_callt &code = to_code_function_call(target->code); | ||
|
|
||
| const exprt &function = code.function(); | ||
| PRECONDITION(function.id()==ID_dereference); |
added 2 commits
September 3, 2018 21:16
This splits up the largest method in the class into two pieces; there is a natural cut put, which is then also exposed as a public interface.
tautschnig
force-pushed
the
split_remove_function_pointer
branch
from
ef87ddd to
10d8b2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits up the largest method in the class into two pieces;
there is a natural cut point, which is then also exposed as a public
interface.